Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLN deprecate bytes_limit from Memory #1447

Merged
merged 2 commits into from Jun 8, 2023

Conversation

tomMoral
Copy link
Contributor

@tomMoral tomMoral commented Jun 1, 2023

The parameter bytes_limit from Memory is misleading as it makes the user believe that this will be enforced automatically, whereas the user needs to call Memory.reduce_size to enforce this.
As this parameter can be directly passed to Memory.reduce_size, along with items_limit and age_limit since #1200, I propose to deprecate it from the Memory class.

@codecov
Copy link

codecov bot commented Jun 1, 2023

Codecov Report

Patch coverage: 90.90% and project coverage change: +0.16 🎉

Comparison is base (d38b002) 94.59% compared to head (a710503) 94.75%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1447      +/-   ##
==========================================
+ Coverage   94.59%   94.75%   +0.16%     
==========================================
  Files          44       44              
  Lines        7361     7366       +5     
==========================================
+ Hits         6963     6980      +17     
+ Misses        398      386      -12     
Impacted Files Coverage Δ
joblib/test/test_memory.py 98.42% <88.88%> (-0.13%) ⬇️
joblib/memory.py 95.18% <100.00%> (+0.02%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ogrisel ogrisel merged commit f6aaaa6 into joblib:master Jun 8, 2023
15 of 16 checks passed
@tomMoral tomMoral deleted the CLN_bytes_limit branch June 28, 2023 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants