New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT: Update byte_bounds import #1501
Conversation
f047bb6
to
e4ed146
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1501 +/- ##
==========================================
- Coverage 94.86% 94.29% -0.57%
==========================================
Files 45 45
Lines 7515 7519 +4
==========================================
- Hits 7129 7090 -39
- Misses 386 429 +43
☔ View full report in Codecov by Sentry. |
e4ed146
to
de8fb1a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
In the unlikely event that someone is going to complain about the array_utils
name and we end up changing it in numpy's main
branch, the code can be updated. This should be safe to merge now.
Thanks, could you please just update the changelog to make it explicit that the next joblib release targets numpy 2.0 compat? |
Sure! I added it. |
The CI failure is weird but unrelated to this PR. |
This PR addresses changes introduced in numpy/numpy#24540 and numpy/numpy#24376 relevant to NEP 52.