Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Update byte_bounds import #1501

Merged
merged 4 commits into from Aug 29, 2023

Conversation

mtsokol
Copy link
Contributor

@mtsokol mtsokol commented Aug 28, 2023

This PR addresses changes introduced in numpy/numpy#24540 and numpy/numpy#24376 relevant to NEP 52.

@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.57% ⚠️

Comparison is base (abd3af7) 94.86% compared to head (68f909d) 94.29%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1501      +/-   ##
==========================================
- Coverage   94.86%   94.29%   -0.57%     
==========================================
  Files          45       45              
  Lines        7515     7519       +4     
==========================================
- Hits         7129     7090      -39     
- Misses        386      429      +43     
Files Changed Coverage Δ
joblib/_memmapping_reducer.py 94.88% <100.00%> (-1.52%) ⬇️

... and 12 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

In the unlikely event that someone is going to complain about the array_utils name and we end up changing it in numpy's main branch, the code can be updated. This should be safe to merge now.

@ogrisel
Copy link
Contributor

ogrisel commented Aug 29, 2023

Thanks, could you please just update the changelog to make it explicit that the next joblib release targets numpy 2.0 compat?

@mtsokol
Copy link
Contributor Author

mtsokol commented Aug 29, 2023

Thanks, could you please just update the changelog to make it explicit that the next joblib release targets numpy 2.0 compat?

Sure! I added it.

@ogrisel
Copy link
Contributor

ogrisel commented Aug 29, 2023

The CI failure is weird but unrelated to this PR.

@ogrisel ogrisel merged commit d6d70ea into joblib:master Aug 29, 2023
14 of 16 checks passed
@mtsokol mtsokol deleted the update-byte-bounds-import branch August 29, 2023 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants