New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vendor cloudpickle 3.0.0 and drop support for Python 3.7. #1515
Conversation
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1515 +/- ##
==========================================
- Coverage 95.10% 95.03% -0.07%
==========================================
Files 45 45
Lines 7553 7553
==========================================
- Hits 7183 7178 -5
- Misses 370 375 +5 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@tomMoral BTW we could probably simplify the loky code base quite significantly by dropping backward compat for Python 3.7. |
cloudpickle does no longer support Python 3.7 (released more than 5 years ago and no longer supported by the CPython team) so we could bump up the dependency.
Note we should bump up the other Python deps on the CI to also test with recent versions of Python 3.12, numpy, dask and such but we should probably do that in a dedicated PR.