Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pytest 8.x compatability #1553

Merged
merged 1 commit into from
Apr 3, 2024
Merged

Add pytest 8.x compatability #1553

merged 1 commit into from
Apr 3, 2024

Conversation

mr-c
Copy link
Contributor

@mr-c mr-c commented Mar 6, 2024

Works with Pytest 7.x+

We needed this patch for the Debian package of joblib as we are switching to Pytest 8.0.2+

Works with Pytest 7.x+
Copy link

codecov bot commented Mar 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 95.06%. Comparing base (6310841) to head (7554ace).

Files Patch % Lines
joblib/test/test_parallel.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1553      +/-   ##
==========================================
- Coverage   95.16%   95.06%   -0.10%     
==========================================
  Files          44       44              
  Lines        7562     7562              
==========================================
- Hits         7196     7189       -7     
- Misses        366      373       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@tomMoral tomMoral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for taking care of the deprecation warnings before it breaks! :)

@tomMoral tomMoral merged commit a8518c4 into joblib:main Apr 3, 2024
18 of 19 checks passed
@mr-c mr-c deleted the pytest8 branch April 3, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants