[MRG] Remove pytest warnings due to yield based tests. #461
Conversation
kdexd
changed the title
|
Oops, github assumed the commit message as PR title already ! |
|
Before I forget it would be good to remove |
kdexd
force-pushed
the
yield-to-assert-simple-replace
branch
from
e381ce0
to
8bc8899
Compare
kdexd
force-pushed
the
yield-to-assert-simple-replace
branch
from
8bc8899
to
33275b1
Compare
|
With test_memory.py and test_parallel.py done, we are already at 36 warnings already! |
|
@lesteve ZERO WARNINGS ! 🏁 💚 |
kdexd
changed the title
| yield check_same_results, dict(n_tasks=25, n_jobs=4, batch_size=7) | ||
| yield check_same_results, dict(n_tasks=10, n_jobs=4, | ||
| pre_dispatch="2*n_jobs") | ||
| check_same_results({'n_tasks': 2, 'n_jobs': 2, 'pre_dispatch': "all"}) |
There was a problem hiding this comment.
Nitpick: typically you could have left the dict here. My personal preference is for the dict literal i.e. {'a': 1, 'b': 2}. Some people like dict apparently because it is more obvious to spot than {} and you don't have to type quotes around the keys. Basically: no strong motivation or no strong consensus -> leave it as it is.
There was a problem hiding this comment.
My motivation is to keep things as uniform as possible, throughout the codebase. Maybe I will tune down its "intensity" 😁
There was a problem hiding this comment.
Yeah it's a very fine equilibrium to find sometimes.
|
NIce very tidy ouput, I like this, great stuff, merging! |
Fourth Phase PR on #411
This PR targets on completely removing all the pytest warnings existing in all the tests at this stage. On
master, at the base of this PR, there are 189 pytest warnings - mostly because pytest >= 3 has deprecated support ofyieldbased tests.Statements
yielding a simple function (callable) have been removed and a normal function call is included there.Statements
yieldingassert_*methods have been replaced with simpleassertkeywords as of now.Finally
--disable-pytest-warningshas been removed.The goal of this PR is to eliminate all pytest warnings existing already.