Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Python 3.8 #936

Merged
merged 3 commits into from
Sep 9, 2019
Merged

Support Python 3.8 #936

merged 3 commits into from
Sep 9, 2019

Conversation

ogrisel
Copy link
Contributor

@ogrisel ogrisel commented Sep 9, 2019

Fixes #927 to support Python 3.8.

@ogrisel ogrisel changed the title Update test for Python 3.8 Update tests for Python 3.8 Sep 9, 2019
@ogrisel ogrisel changed the title Update tests for Python 3.8 Support Python 3.8 Sep 9, 2019
@codecov
Copy link

codecov bot commented Sep 9, 2019

Codecov Report

Merging #936 into master will decrease coverage by 0.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #936      +/-   ##
==========================================
- Coverage    95.4%   95.38%   -0.02%     
==========================================
  Files          45       45              
  Lines        6460     6462       +2     
==========================================
+ Hits         6163     6164       +1     
- Misses        297      298       +1
Impacted Files Coverage Δ
joblib/hashing.py 93.16% <100%> (ø) ⬆️
joblib/test/test_module.py 94.44% <50%> (-5.56%) ⬇️
joblib/test/test_store_backends.py 91.17% <0%> (-5.89%) ⬇️
joblib/_parallel_backends.py 93.6% <0%> (-0.81%) ⬇️
joblib/disk.py 88.33% <0%> (+6.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd585ce...5706ee3. Read the comment docs.

@ogrisel
Copy link
Contributor Author

ogrisel commented Sep 9, 2019

The coverage drop is expected as long as we don't have a Python 3.8 CI but we need to wait for the 3.8 release first...

@ogrisel ogrisel merged commit 79f3fb3 into joblib:master Sep 9, 2019
@ogrisel ogrisel deleted the python-3.8 branch September 9, 2019 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests errors on Python 3.8 (GIT master)
1 participant