DOC Warn if coexisting libomp / libiomp on MacOS #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogrisel
approved these changes
Jul 10, 2023
|
Could you please document the change in the warning in the changelog? |
ogrisel
reviewed
Jul 10, 2023
|
|
||
| Surprisingly, we never encountered this kind of issue on macOS, where this mix | ||
| is the most frequent (Clang being the default C compiler on macOS). | ||
| LLVM/Clang instead of GCC (this is the case for instance with conda's default channel). |
There was a problem hiding this comment.
Could you also please mention the possibility to use export MKL_THREADING_LAYER=tbb as a workaround on macOS in the subsequent paragraph?
8 tasks
ogrisel
reviewed
Jul 11, 2023
ogrisel
reviewed
Jul 11, 2023
|
Merged, thanks @jeremiedbb! |
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
Jul 17, 2023
3.2.0 (2023-07-13) ================== - Dropped support for Python 3.6 and 3.7. - Added support for custom library controllers. Custom controllers must inherit from the `threadpoolctl.LibController` class and be registered to threadpoolctl using the `threadpoolctl.register` function. joblib/threadpoolctl#138 - A warning is raised on macOS when threadpoolctl finds both Intel OpenMP and LLVM OpenMP runtimes loaded simultaneously by the same Python program. See details and workarounds at https://github.com/joblib/threadpoolctl/blob/master/multiple_openmp.md. joblib/threadpoolctl#142
1 task
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to ContinuumIO/anaconda-issues#13221
and scikit-learn-contrib/imbalanced-learn#984
Looks like it's possible to have some crashes due to both libraries coexisting in the same python program on MacOS afterall.
I removed the linux only filter for the warning, but then it means all macos users installing from conda default channel will get this warning. Is it something that we want ?