Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] E-Hentai/ExHentai duplicate search results when yousing page or rating filter #63

Closed
randolph24 opened this issue Jul 18, 2020 · 11 comments
Labels
Bug Something isn't working Will close next release

Comments

@randolph24
Copy link

Device information

  • Tachiyomi version: Preview r165
  • Android version: 8.0.0
  • Device: Samsung Galaxy S7 edge SM-G935F

Steps to reproduce

  1. As source select E-Hentai or ExHentai
  2. Activate a page or rating filter

Expected behavior

Filtered results where each entry only appears once.

Actual behavior

Some search results are duplicated and repeat. These are not different versions or translations, but really the same entries. This is also visible by the exactly identical upload date and the reading progress which changes in both entries simultaneously.

Other details

Screenshot_20200718-154036_TachiyomiSY
Screenshot_20200718-154050_TachiyomiSY
Screenshot_20200718-154107_TachiyomiSY

@randolph24 randolph24 added the Bug Something isn't working label Jul 18, 2020
@jobobby04
Copy link
Owner

I cannot reproduce, if you continue to get this error in the next version of the app you can notify me and I will reopen this

@randolph24
Copy link
Author

I tried it again with the newest preview(184) and the bug still persists. I also tried it with two different device and there the bug also appears. The bug also is around a long time. It already apeared in TachiEH and TachAZ. It would be nice if the bug could be fixed eventually, because at the moment the ratings filter and pages filter are not very useful becaise of it.

Screenshot_20200730-232033_TachiyomiSY
Screenshot_20200730-231837_TachiyomiSY

@jobobby04 jobobby04 reopened this Oct 12, 2020
@crisalis2
Copy link

crisalis2 commented Dec 21, 2020

This has also happened to me for a long time. If you try more specific searches, and restricted to a single language, it will be easier to reproduce and detect.

@joseph619
Copy link

joseph619 commented Mar 28, 2021

@randolph24 @crisalis2 Install the latest preview build tell if this still happen for you

@crisalis2
Copy link

I installed the latest preview and it still happens. For example, selecting only the "Non-H" genre and setting the Minimum Pages (this is important) to 50, I get this:
image

@jondoe2021
Copy link

I am also able to reproduce this issue. This is a valid bug. Please fix.

OncePunchedMan pushed a commit to OncePunchedMan/TachiyomiSY that referenced this issue May 9, 2021
@jobobby04
Copy link
Owner

I found why duplicate results show in E/ExHentai search, if your watched filters filter out more then 25 results on any search, it combines 2 pages together, but SY doesnt know it did that, so if it combined pages 2 and 3, SY would still request 3

nsbgflQ 1

@jobobby04
Copy link
Owner

Actually its a bit different, but similar, they do a hacky thing that forces the page to only show 25 results, all the time, by combining the results from the next page into this one, and adding a &from parameter to the next page for the last gallery of this page

@joseph619
Copy link

joseph619 commented Jun 15, 2021

Apparently EhViewer fixed it, but a fix would require duplicate dirty code. For reference (from Discord)

seven332/EhViewer@8b76eaa

Also related: seven332/EhViewer@1cbb725

@jobobby04
Copy link
Owner

Finally got around to making a fix for this, will be included in the next build

@jobobby04
Copy link
Owner

Addressed by e8100fc

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug Something isn't working Will close next release
Projects
None yet
Development

No branches or pull requests

5 participants