Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add module with Milky-Way-like potentials #395

Merged
merged 32 commits into from
Aug 8, 2019
Merged

Add module with Milky-Way-like potentials #395

merged 32 commits into from
Aug 8, 2019

Commits on Jul 31, 2019

  1. Start on galpy.potential.mwpotentials module, add existing Milky Way … 

    …potentials (MWPotential and MWPotential2014)
    @jobovy
    jobovy committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    de066cd View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2019

  1. Also pop 'quantity' keyword in physical conversion

    @jobovy
    jobovy committed Aug 1, 2019
    Configuration menu
    Copy the full SHA
    d81f32b View commit details
    Browse the repository at this point in the history

  2. Add Mcillan (2017) potential, in such a way as to allow it to be lazi… 

    …ly-loaded

Co-authored-by:  Ted Mackereth <tedmackereth@gmail.com>
    @jobovy @jmackereth
    jobovy and jmackereth committed Aug 1, 2019
    Configuration menu
    Copy the full SHA
    add13be View commit details
    Browse the repository at this point in the history

  3. Add test that McMillan (2017) implementation gives correct values for… 

    … quantities listed in the paper
    @jobovy
    jobovy committed Aug 1, 2019
    Configuration menu
    Copy the full SHA
    6284ff7 View commit details
    Browse the repository at this point in the history

  4. Allow lazy-loading of expensive potentials in Python 2

    @jobovy
    jobovy committed Aug 1, 2019
    Configuration menu
    Copy the full SHA
    7a63ab4 View commit details
    Browse the repository at this point in the history

  5. Raise AttributeError in mwpotentials and _mcmillan class modules when… 

    … asked for an attribute that doesn't exist
    @jobovy
    jobovy committed Aug 1, 2019
    Configuration menu
    Copy the full SHA
    e63c393 View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2019

  1. Start on Mixin to compute forces as numerical derivatives

    @jobovy
    jobovy committed Aug 5, 2019
    Configuration menu
    Copy the full SHA
    4934606 View commit details
    Browse the repository at this point in the history

  2. Switch to 2nd-order forward difference method for numerical R derivative

    @jobovy
    jobovy committed Aug 5, 2019
    Configuration menu
    Copy the full SHA
    ead0828 View commit details
    Browse the repository at this point in the history

  3. Add second order numerical derivatives of Potentials X2deriv

    @jobovy
    jobovy committed Aug 5, 2019
    Configuration menu
    Copy the full SHA
    18f936b View commit details
    Browse the repository at this point in the history

  4. Pass kwargs, not **kwargs, to NumericalPotentialDerivativesMixin to g… 

    …et a reference to kwargs that can be popped, not a copy; add docs
    @jobovy
    jobovy committed Aug 5, 2019
    Configuration menu
    Copy the full SHA
    fc05332 View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2019

  1. Add mixed Rz and Rphi numerical derivatives

    @jobovy
    jobovy committed Aug 6, 2019
    Configuration menu
    Copy the full SHA
    7056ee1 View commit details
    Browse the repository at this point in the history

  2. Add NumericalDerivativesMixin to top potential level

    @jobovy
    jobovy committed Aug 6, 2019
    Configuration menu
    Copy the full SHA
    8356cb2 View commit details
    Browse the repository at this point in the history

  3. Add basic tests of NumericalPotentialDerivativesMixin

    @jobovy
    jobovy committed Aug 6, 2019
    Configuration menu
    Copy the full SHA
    1532a9d View commit details
    Browse the repository at this point in the history

  4. Explicitly comment out not-implemented 2nd derivatives in DiskSCFPote… 

    …ntial so they can be overriden by NumericalPotentialDerivativesMixin
    @jobovy
    jobovy committed Aug 6, 2019
    Configuration menu
    Copy the full SHA
    206974f View commit details
    Browse the repository at this point in the history

  5. Add numerical second derivatives for McMillan17 potential

    @jobovy
    jobovy committed Aug 6, 2019
    Configuration menu
    Copy the full SHA
    ab245f1 View commit details
    Browse the repository at this point in the history

  6. Remove NumericalPotentialDerivativesMixin from tests that run on all … 

    …potentials
    @jobovy
    jobovy committed Aug 6, 2019
    Configuration menu
    Copy the full SHA
    3033640 View commit details
    Browse the repository at this point in the history

  7. Add numerical second derivatives to SCFPotential

    @jobovy
    jobovy committed Aug 6, 2019
    Configuration menu
    Copy the full SHA
    6836de8 View commit details
    Browse the repository at this point in the history

  8. Now that SCFPotential has (numerical) second derivatives, can use Dis… 

    …kSCFPotential code to compute its second derivatives
    @jobovy
    jobovy committed Aug 6, 2019
    Configuration menu
    Copy the full SHA
    ccf2059 View commit details
    Browse the repository at this point in the history

  9. Switch back to using SCF and DiskSCFPotential to build McMillan17 pot… 

    …ential
    @jobovy
    jobovy committed Aug 6, 2019
    Configuration menu
    Copy the full SHA
    1633e4f View commit details
    Browse the repository at this point in the history

  10. Turn tests of second derivatives of DiskSCFPotential on

    @jobovy
    jobovy committed Aug 6, 2019
    Configuration menu
    Copy the full SHA
    9f72ce6 View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2019

  1. Don't cover __dir__ and AttributeError exception

    @jobovy
    jobovy committed Aug 7, 2019
    Configuration menu
    Copy the full SHA
    e716688 View commit details
    Browse the repository at this point in the history

  2. Remove unnecessary lazy-loading functionality in _mcmillan17 (because… 

    … done in mwpotentials)
    @jobovy
    jobovy committed Aug 7, 2019
    Configuration menu
    Copy the full SHA
    52f4761 View commit details
    Browse the repository at this point in the history

  3. Add Model I from Irrgang et al. (2013)

    @jobovy
    jobovy committed Aug 7, 2019
    Configuration menu
    Copy the full SHA
    e392387 View commit details
    Browse the repository at this point in the history

  4. Add test that values of implementation of Irrgang et al. (2013) model… 

    … I agree with their Table values
    @jobovy
    jobovy committed Aug 7, 2019
    Configuration menu
    Copy the full SHA
    59685e8 View commit details
    Browse the repository at this point in the history

  5. Add Milky-Way mass model II from Irrgang et al. (2013)

    @jobovy
    jobovy committed Aug 7, 2019
    Configuration menu
    Copy the full SHA
    7977602 View commit details
    Browse the repository at this point in the history

  6. Add test that values of implementation of Irrgang et al. (2013) model… 

    … II agree with their Table values
    @jobovy
    jobovy committed Aug 7, 2019
    Configuration menu
    Copy the full SHA
    b0ccf28 View commit details
    Browse the repository at this point in the history

  7. Add Milky-Way mass model III from Irrgang et al. (2013)

    @jobovy
    jobovy committed Aug 7, 2019
    Configuration menu
    Copy the full SHA
    b00e483 View commit details
    Browse the repository at this point in the history

  8. Add test that values of implementation of Irrgang et al. (2013) model… 

    … III agree with their Table values
    @jobovy
    jobovy committed Aug 7, 2019
    Configuration menu
    Copy the full SHA
    3fb9c9f View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2019

  1. Merge branch 'master' into mwpotentials

    @jobovy
    jobovy committed Aug 8, 2019
    Configuration menu
    Copy the full SHA
    4c0b453 View commit details
    Browse the repository at this point in the history

  2. Add a section to the documentation about the new Milky-Way potentials

    @jobovy
    jobovy committed Aug 8, 2019
    Configuration menu
    Copy the full SHA
    29668b0 View commit details
    Browse the repository at this point in the history

  3. Add galpy.potential.mwpotentials to HISTORY

    @jobovy
    jobovy committed Aug 8, 2019
    Configuration menu
    Copy the full SHA
    f5a0808 View commit details
    Browse the repository at this point in the history

  4. Update PR number

    @jobovy
    jobovy committed Aug 8, 2019
    Configuration menu
    Copy the full SHA
    ced0943 View commit details
    Browse the repository at this point in the history