Add general classes for implementing spherical potentials and interpolated spherical potentials #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…polated range when using interpSphericalPotential
…lipsoidalPotential, using the SphericalPotential way) and use this to implement interpSphericalPotential in C
…plicitly implemented
…ng the Poisso =n eqn. at r < rmax and set to zero outside to avoid numerical issues
jobovy
changed the title
Codecov Report
@@ Coverage Diff @@
## master #424 +/- ##
========================================
Coverage 99.81% 99.82%
========================================
Files 162 166 +4
Lines 24947 25141 +194
========================================
+ Hits 24902 25096 +194
Misses 45 45
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds:
SphericalPotential: a general class for defining spherical potentials from functions representing the potential, radial force, force derivative, and density as a function of spherical radius (the natural way to define these)interpSphericalPotential: a general class for defining interpolated versions of spherical potentialsBoth implemented in both Python and C. Use of
SphericalPotentialin C mirrors that ofEllipsoidalPotential.