-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spherical coordinate support #427
Conversation
Codecov Report
@@ Coverage Diff @@
## master #427 +/- ##
========================================
Coverage 99.81% 99.82%
========================================
Files 162 166 +4
Lines 24947 25173 +226
========================================
+ Hits 24902 25128 +226
Misses 45 45
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, just a few very minor comments. I generated the docs and they look fine for me, so perhaps an issue with sphinx on your end? Anyway, docs seem fine.
Add spherical coordinate methods to orbit.Orbit and cylindrical <--> spherical transformation methods to util.bovy_coords