Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spherical coordinate support #427

Merged
merged 8 commits into from
Jul 22, 2020
Merged

Spherical coordinate support #427

merged 8 commits into from
Jul 22, 2020

Conversation

jamesmlane
Copy link
Contributor

Add spherical coordinate methods to orbit.Orbit and cylindrical <--> spherical transformation methods to util.bovy_coords

@codecov
Copy link

codecov bot commented Jul 21, 2020

Codecov Report

Merging #427 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master     #427    +/-   ##
========================================
  Coverage   99.81%   99.82%            
========================================
  Files         162      166     +4     
  Lines       24947    25173   +226     
========================================
+ Hits        24902    25128   +226     
  Misses         45       45            
Impacted Files Coverage Δ
galpy/orbit/Orbits.py 99.94% <100.00%> (+<0.01%) ⬆️
galpy/util/bovy_coords.py 100.00% <100.00%> (ø)
galpy/potential/__init__.py 100.00% <0.00%> (ø)
galpy/orbit/integrateFullOrbit.py 100.00% <0.00%> (ø)
galpy/orbit/integratePlanarOrbit.py 100.00% <0.00%> (ø)
galpy/potential/BurkertPotential.py 100.00% <0.00%> (ø)
galpy/potential/SphericalShellPotential.py 100.00% <0.00%> (ø)
galpy/orbit/orbit_c_ext/integrateFullOrbit.c 100.00% <0.00%> (ø)
galpy/orbit/orbit_c_ext/integratePlanarOrbit.c 100.00% <0.00%> (ø)
...lpy/potential/potential_c_ext/SphericalPotential.c 100.00% <0.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34a9307...e6be6a0. Read the comment docs.

Copy link
Owner

@jobovy jobovy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just a few very minor comments. I generated the docs and they look fine for me, so perhaps an issue with sphinx on your end? Anyway, docs seem fine.

tests/test_orbit.py Show resolved Hide resolved
galpy/orbit/Orbits.py Outdated Show resolved Hide resolved
galpy/orbit/Orbits.py Outdated Show resolved Hide resolved
galpy/orbit/Orbits.py Outdated Show resolved Hide resolved
galpy/util/bovy_coords.py Outdated Show resolved Hide resolved
@jobovy jobovy self-assigned this Jul 22, 2020
@jobovy jobovy added this to the v1.7 milestone Jul 22, 2020
@jobovy jobovy merged commit 11ae3cd into jobovy:master Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants