Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Spherical DFs #432

Merged
merged 99 commits into from Sep 14, 2020
Merged

Add Spherical DFs #432

merged 99 commits into from Sep 14, 2020

Conversation

jamesmlane
Copy link
Contributor

Adds basic spherical isotropic & anisotropic DF evaluation, sampling, and moment framework. Completely implements Hernquist and King DFs.

jobovy and others added 30 commits July 9, 2020 12:14
@jobovy
Add basic structure for implementing spherical distribution functions
676c11e
@jobovy
Basic solution of the King DF density
81609e3
@jobovy
Better in-code comments [ci skip]
4a52ada
@jobovy
Merge branch 'interpsphericalpotential' into kingpotential
2ccd40d
@jobovy
Also store dW/dr for use in setting up KingPotential
41d6ffd
@jobovy
Add Potential for the King model, using interpSphericalPotential
50a6679
@jobovy
Merge branch 'interpsphericalpotential' into kingpotential
82f79ef
@jobovy
Add KingPotential to top level
06767dd
@jobovy
Merge branch 'interpsphericalpotential' into kingpotential
15f5187
@jobovy
Merge branch 'interpsphericalpotential' into kingpotential
67cfb26
@jobovy
Slightly loosen Liouville test tolerance for KingPotential
eeb5f96
@jamesmlane
Add __init__ and imports for constantbetaHernquistdf
30f147b
@jamesmlane
Add __call_internal__ for constantbetaHernquistdf
45b51a3
@jamesmlane
Add functions for calculating f1E
5fdaa96
@jamesmlane
Add __init__ and imports for constantbetadf
3d0002e
@jamesmlane
Add __init__ and __call_internal__ for isotropicHernquistdf
9ff6f01
@jamesmlane
Imports for sphericaldf
164860b
@jamesmlane
Add __init__ for sphericaldf
bf06f7b
@jamesmlane
Add __call__ for sphericaldf
1be08c1
@jamesmlane
Add top-level sample function for sphericaldf
cdf125a
@jamesmlane
Add position sampling functions
f6a5a98
@jamesmlane
Add top-level velocity sampling functions
4dac058
@jamesmlane
Add __init__ for anisotropicsphericaldf
a030ae9
@jamesmlane
Add functions for sampling eta
f137db1
@jamesmlane
Set f1=0 for out-of-bounds energies
e9d880d
@jamesmlane
Make _scale attribute from potential
3696c67
@jamesmlane
Add _scale, single pot check, cmf_interpolator to __init__
17a42a5
@jamesmlane
Fix astropy units .to syntax
c6de685
@jamesmlane
Change position sampling to xi formalism
a8b983d
@jamesmlane
Implements simplified velocity sampling
ffcaa28
@jobovy
Add test of interpolating the inverse cumulative mass function
e356e23
@jobovy
Test of errors when not supplying a Hernquist potential to the Hernqu…
af2b9dd 
…ist DFs
@jobovy
phi0 -> psi0
736e7d8
@jobovy
Different scale handling in sphericaldf
7b6525a
@jobovy
Test out-of-bounds behavior of (an)isotropic Hernquist DF
6ab7876
@jobovy
Test more W0 cases of kingdf and also compare vmomentdensity to densi…
d5e9af6 
…ty directly
@jobovy
No need to deal with vmax < vesc in building the p(v|r) grid any longer
082fcc7
@jobovy
Also need theta when sampling at a single position
3f374b7
@jobovy
Tests of sampling a spherical DF at a single location
de78197
@jobovy
Also don't need the factor of two in constantbetadf's vmomentdensity
4184a16
@jobovy
Test the units of the output orbits from sampling a spherical DF
daec37a
@jobovy
Test of R,vR,... output of spherical DF sampling
7a22257
@jobovy
Test the different ways of calling the ergodic and anisotropic DFs
d15cf4a
@jobovy
Test of initializing KingPotential with parameters with units
41734ce
@jobovy
Lowercase eddingtondf for more consistency(-ish...)
40cb173
@jobovy
Actually rename Eddingtondf --> eddingtondf for conistency
f417fcb
@jobovy
Add missing factor of r^-2beta in vmomentdensity of constantbetadf
31eec2d
@jobovy
Add unit outputs for sphericaldf.vmomentdensity
5e78624
@jobovy
Fix units of KingPotential used in kingdf
78fb3a8
@jobovy
Add a bunch of tests of quantity handling of the sphericaldfs
cbf5773
@jobovy
Change kingdf normalization such that the DF is the number density
04afc72
@jobovy
Tests of the normalization of the isotropic and anisotropic Hernquist…
8f7d069 
… DFs (currently fails, because the anisotropic normalization isn't right)
@jobovy
Move _call_internal to general isotropicsphericaldf, add some notes a…
d24cedc 
…bout sphericaldfs
@jobovy
Fix forcevmoment test for new vmoment implementation and make sure to…
5c84aaa 
… hit non-quantity output
@jobovy
Fix normalization of Baes & Dejonghe
9fd3685
@jobovy
Make sure to use a Hernquist mass that's not 1, remove expected failure
64845f4
@codecov
Copy link

codecov bot commented Sep 14, 2020 •
edited

Codecov Report

Merging #432 into master will increase coverage by 10.13%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #432       +/-   ##
===========================================
+ Coverage   89.68%   99.82%   +10.13%     
===========================================
  Files         168      175        +7     
  Lines       24889    25267      +378     
===========================================
+ Hits        22321    25222     +2901     
+ Misses       2568       45     -2523
Impacted Files Coverage Δ
galpy/df/__init__.py 100.00% <100.00%> (ø)
galpy/df/constantbetaHernquistdf.py 100.00% <100.00%> (ø)
galpy/df/constantbetadf.py 100.00% <100.00%> (ø)
galpy/df/eddingtondf.py 100.00% <100.00%> (ø)
galpy/df/isotropicHernquistdf.py 100.00% <100.00%> (ø)
galpy/df/kingdf.py 100.00% <100.00%> (ø)
galpy/df/sphericaldf.py 100.00% <100.00%> (ø)
galpy/potential/KingPotential.py 100.00% <100.00%> (ø)
galpy/potential/__init__.py 100.00% <100.00%> (ø)
... and 64 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ed100e...64845f4. Read the comment docs.

@jobovy jobovy merged commit 2c1599b into jobovy:master Sep 14, 2020
@jobovy
Copy link
Owner

jobovy commented Sep 14, 2020

Looks great, thanks!

@jobovy jobovy added this to the v1.7 milestone Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.7
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jamesmlane @jobovy