Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds starting index to range of cml_pvr used to make interpolator #433

Merged
merged 2 commits into from
Oct 2, 2020

Conversation

jamesmlane
Copy link
Contributor

Uses start_indx to set minimum value of cml_pvr used to make 1D cumulative p(v|r) -> v_vesc interpolators. Ensures when the DF is negative or 0 for a non-zero v_vesc that the interpolator can properly initialize and be used to sample v_vesc.

@codecov
Copy link

codecov bot commented Oct 2, 2020

Codecov Report

Merging #433 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #433   +/-   ##
=======================================
  Coverage   99.82%   99.82%           
=======================================
  Files         175      175           
  Lines       25267    25272    +5     
=======================================
+ Hits        25222    25227    +5     
  Misses         45       45           
Impacted Files Coverage Δ
galpy/df/sphericaldf.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 130fca1...6cc2451. Read the comment docs.

@jobovy
Copy link
Owner

jobovy commented Oct 2, 2020

Looks good, thanks! I may add a warning that the DF appears to have negative parts before merging...

@jobovy jobovy merged commit 15f35b9 into jobovy:master Oct 2, 2020
@jobovy jobovy added this to the v1.7 milestone Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants