Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't flatten Potential instances #436

Merged
merged 1 commit into from
Nov 12, 2020

Conversation

nstarman
Copy link
Contributor

first check its a Potential

Signed-off-by: Nathaniel Starkman (@nstarman) nstarkman@protonmail.com

Signed-off-by: Nathaniel Starkman (@nstarman) <nstarkman@protonmail.com>
@nstarman
Copy link
Contributor Author

nstarman commented Nov 12, 2020

I also got CompositePotential to completely work. It operates and looks like a list. should I push in different PR?
It also works when nested, just like the list of potentials.

@nstarman
Copy link
Contributor Author

@jobovy
Copy link
Owner

jobovy commented Nov 12, 2020

Thanks, this is a very straightforward way to fix the issue you're having while not affecting any of the other code!

Let's hold off for now on the CompositePotential, I need to think more about how that would mesh with the rest of the code.

With travis slow these days, it will be a while until the tests all run...

@jobovy jobovy added this to the v1.7 milestone Nov 12, 2020
@codecov
Copy link

codecov bot commented Nov 12, 2020

Codecov Report

Merging #436 (f7327cd) into master (5afb023) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #436   +/-   ##
=======================================
  Coverage   99.82%   99.82%           
=======================================
  Files         176      176           
  Lines       25332    25380   +48     
=======================================
+ Hits        25287    25335   +48     
  Misses         45       45           
Impacted Files Coverage Δ
galpy/potential/Potential.py 100.00% <100.00%> (ø)
galpy/util/coords.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5afb023...f7327cd. Read the comment docs.

@jobovy jobovy merged commit 9c4daed into jobovy:master Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants