Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix keyword para issue in galpy.orbit.Orbits.Orbit._call_internal #569

Merged
merged 2 commits into from May 9, 2023

Conversation

azz147
Copy link
Contributor

@azz147 azz147 commented May 9, 2023

fix #565 , add a new test test_call_internal_kwargs in tests/test_orbit.py to test the results are the same when use/not use keyword parameter t.

@codecov
Copy link

codecov bot commented May 9, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (655ad6a) 99.91% compared to head (176916b) 99.91%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #569   +/-   ##
=======================================
  Coverage   99.91%   99.91%           
=======================================
  Files         196      196           
  Lines       28891    28893    +2     
=======================================
+ Hits        28867    28869    +2     
  Misses         24       24           
Impacted Files Coverage Δ
galpy/orbit/Orbits.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jobovy jobovy merged commit 9ea569f into jobovy:main May 9, 2023
62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

keyword parameter t in galpy.orbit.Orbits.Orbit._call_internal will be ignored in some cases
2 participants