Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] JobServerFilter.onProcessingFailed is not called when a job orphans (e.g. if background job server dies) #920

Closed
rdehuyss opened this issue Jan 23, 2024 · 1 comment

Comments

@rdehuyss
Copy link
Contributor

JobRunr Version

7.0.0-beta3

JDK Version

1.8

Your SQL / NoSQL database

NA

What happened?

I have a batch that takes some time to create and enqueue the child jobs.
I have a job filter that implements ApplyStateFilter, JobServerFilter, JobClientFilter, BatchJobFilter
Let s say I only have one jobrunr server processing the jobs.

If I start the batch and voluntarily kill my server while it is doing its JobRequestHandler.run, and then I restart jobrunr
then the BatchJobFilter.onBatchJobFailed is not called even if ApplyStateFilter.onStateApplied is called

How to reproduce?

Relevant log output

No response

rdehuyss added a commit that referenced this issue Jan 23, 2024
rdehuyss added a commit that referenced this issue Jan 23, 2024
rdehuyss added a commit that referenced this issue Jan 23, 2024
rdehuyss added a commit that referenced this issue Jan 23, 2024
@rdehuyss
Copy link
Contributor Author

Fixed in v7 branch by PR #921.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant