Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly commit in case of autoCommit=false. #129

Merged
merged 2 commits into from May 25, 2021

Conversation

tan9
Copy link
Contributor

@tan9 tan9 commented May 25, 2021

Explicitly commit in all updating operations in Sql and all its subclasses.

Fixes #128

@rdehuyss rdehuyss merged commit 84a61ac into jobrunr:master May 25, 2021
@tan9 tan9 deleted the issue/fail-when-no-auto-commit branch May 25, 2021 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] SqlStorageProvider assumes that all DataSources are autoCommit enabled.
2 participants