Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Quarkus 3.5 #886

Merged
merged 1 commit into from Dec 8, 2023
Merged

Upgrade to Quarkus 3.5 #886

merged 1 commit into from Dec 8, 2023

Conversation

tms0
Copy link
Contributor

@tms0 tms0 commented Nov 30, 2023

Hi @rdehuyss ,

Yet another Quarkus PR ;-) And it's another critical one for my projet.

There have been a breaking change in Quarkus that make the extension crashing with Quarkus >= 3.5.x. A deprecated method has beean deleted on the BeanContainer API : quarkusio/quarkus@4f2aa80

Also, the elasticsearch-high-level-client extension has been deleted (since 3.3.x), so the capability constant is not available anymore : quarkusio/quarkus@80139bc.

I tested it with success against quarkus 3.2.6 and 3.5.1 using MongoDB as a database. But I didn't succed to test the Elasticsearch integration, it seems to be already broken with the latest jobrunr version.

@cla-bot cla-bot bot added the cla-signed label Nov 30, 2023
@rdehuyss
Copy link
Contributor

Hi Valentin, please change the base for the PR to the v7 branch.

Also, this PR will only be released with v7. These days there are so many changes on Quarkus that it's difficult to keep up to date. In the 3 branch there were already quite a lot of breaking changes which do not follow the semver versioning.

v7 will be released somewhere in Q1 2024.

@tms0 tms0 changed the base branch from master to v7 December 4, 2023 15:30
@tms0 tms0 force-pushed the fix-quarkus-3.5 branch 2 times, most recently from c0dd537 to 433a3d8 Compare December 5, 2023 08:45
Copy link
Contributor

@rdehuyss rdehuyss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rdehuyss rdehuyss merged commit 3eb2ee5 into jobrunr:v7 Dec 8, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants