Upgrade frontend packages #917
Conversation
There was a problem hiding this comment.
Great work. I love the StatCard and think we should use a similar approach for the problems and the different state components.
I also have the impression that the overall font-size is smaller. Is that possible or is my eyesight getting worse 🤓?
I also noticed that if there are 2 warnings and an error in the dashboard and I dismiss only one warning, the 2 of them are gone. I also think the error should go on top.
I would also like to add eslint and prettier. However, since trying it, Intellij consumes all my CPU
...r/dashboard/frontend/src/components/overview/problems/cpu-allocation-irregularity-problem.js
Outdated
Show resolved
Hide resolved
| const classes = { | ||
| alert: { | ||
| fontSize: '1rem' | ||
| } | ||
| })); | ||
| }; |
There was a problem hiding this comment.
When do we use inline styles (like job-code) vs classes (like here)?
There was a problem hiding this comment.
See also my later comment about style duplication of the problem cards. What's your opinion on this?
...rc/main/resources/org/jobrunr/dashboard/frontend/src/components/jobs/states/deleted-state.js
Outdated
Show resolved
Hide resolved
...main/resources/org/jobrunr/dashboard/frontend/src/components/jobs/states/processing-state.js
Show resolved
Hide resolved
...src/main/resources/org/jobrunr/dashboard/frontend/src/components/overview/cards/stat-card.js
Outdated
Show resolved
Hide resolved
core/src/main/resources/org/jobrunr/dashboard/frontend/src/components/utils/highlighter.js
Show resolved
Hide resolved
| const classes = { | ||
| footer: { | ||
| paddingTop: '1rem', | ||
| width: '100%', | ||
| display: 'inline-block' | ||
| } | ||
| })); | ||
| }; |
There was a problem hiding this comment.
Should we inline this or not? See earlier comment about consistency.
core/src/main/resources/org/jobrunr/dashboard/frontend/src/components/jobs/job-view.js
Outdated
Show resolved
Hide resolved
I checked with chrome font-sizes are still the same.
Should be fixed. |
| @@ -148,7 +146,7 @@ const JobView = (props) => { | |||
| const mustGoBack = 'delete' === apiStatus.type; | |||
| setApiStatus(null); | |||
| if (mustGoBack) { | |||
| history.goBack(); | |||
| navigate(-1); | |||
There was a problem hiding this comment.
Is this still necessary?
No description provided.