Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for GitHub save failing #68

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .eslintrc.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
module.exports = {
"env": {
"browser": true,
"es6": true
"es6": true,
"node": true
},
"settings": {
"react": {
Expand Down
28 changes: 25 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -37,10 +37,32 @@ git clone https://github.com/emilyskidsister/hacklily.git

### Running (without GitHub integration)

Once you have installed the above dependencies, run
Once you have installed the above dependencies, run:

```bash
make serve
yarn install
yarn build
yarn start
```

Or if using npm:

```bash
npm install
npm run build
npm start
```

To use the remote backend (rather than building your own local renderer), **in place of the `start` command**, use:

```bash
yarn start:remote-backend
```

or:

```bash
npm run start:remote-backend
```

### Running (with GitHub integration)
Expand All @@ -52,7 +74,7 @@ If you specifically wish to test integration with GitHub, follow the steps in th
First, create a GitHub organization by following the steps at https://github.com/organizations/new.
Select the free plan.

Next, create a new app at https://github.com/organizations/<your-new-repo-name>/settings/applications,
Next, create a new app at https://github.com/organizations/your-new-repo-name/settings/applications,
making note of the client ID and secret. This application will be used to allow users to log in.

To run the frontend, in one shell run:
Expand Down
4 changes: 2 additions & 2 deletions server/renderer/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
FROM debian:sid-slim
RUN apt-get update && apt-get install --no-install-recommends -y ruby curl bzip2 git locales gsfonts ghostscript fonts-dejavu-extra psmisc emacs-intl-fonts xfonts-intl-.* fonts-ipafont-mincho xfonts-bolkhov-75dpi xfonts-cronyx-100dpi xfonts-cronyx-75dpi patch python2 python3 && \
FROM --platform=linux/amd64 debian:sid-slim
RUN apt-get update && apt-get install --no-install-recommends -y adduser ruby curl bzip2 git locales gsfonts ghostscript fonts-dejavu-extra psmisc emacs-intl-fonts xfonts-intl-.* fonts-ipafont-mincho xfonts-bolkhov-75dpi xfonts-cronyx-100dpi xfonts-cronyx-75dpi patch python3 && \
localedef -i en_US -c -f UTF-8 -A /usr/share/locale/locale.alias en_US.UTF-8 && \
curl -L https://github.com/stedolan/jq/releases/download/jq-1.5/jq-linux64 > /usr/local/bin/jq && \
chmod +x /usr/local/bin/jq && echo 42 | jq .
Expand Down
3 changes: 3 additions & 0 deletions webpack.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,9 @@ module.exports = {
plugins: [
new CopyPlugin({ patterns: [path.resolve(__dirname, "static")] }),
new MonacoWebpackPlugin(),
new webpack.DefinePlugin({
'process.env': JSON.stringify(process.env)
}),
new webpack.EnvironmentPlugin([
"REACT_APP_GITHUB_CLIENT_ID",
"REACT_APP_BACKEND_WS_URL",
Expand Down