Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid Secret #2

Closed
cwchristerw opened this issue May 6, 2019 · 5 comments
Closed

Invalid Secret #2

cwchristerw opened this issue May 6, 2019 · 5 comments

Comments

@cwchristerw
Copy link

I want to make sure all kinds of secret are supported but for some reason I cannot use Epic Games style secret like this JVIVET2MKBJUEU2TIZCVORCCJ5GTON2HKNGFOT2FIRCUGT2EIRIQ (this not valid anymore)

@cwchristerw
Copy link
Author

PHP Error:

Fatal error: Uncaught Exception: Invalid secret provided. Secret: "JVIVET2MKBJUEU2TIZCVORCCJ5GTON2HKNGFOT2FIRCUGT2EIRIQ" in {FOLDER}/system/external/jocic/google-authenticator/source/Jocic/GoogleAuthenticator/Secret.php:194 Stack trace: #0 {FOLDER}/system/external/jocic/google-authenticator/source/Jocic/GoogleAuthenticator/Secret.php(128): Jocic\GoogleAuthenticator\Secret->setValue('JVIVET2MKBJUEU2...') #1 {FOLDER}/system/external/jocic/google-authenticator/source/Jocic/GoogleAuthenticator/Account.php(339): Jocic\GoogleAuthenticator\Secret->__construct('JVIVET2MKBJUEU2...') #2 {FOLDER}/system/external/jocic/google-authenticator/source/Jocic/GoogleAuthenticator/Account.php(128): Jocic\GoogleAuthenticator\Account->setAccountSecret('JVIVET2MKBJUEU2...') #3 {FOLDER}/system/datastore/n1cqm5613748d7246cp9v9ykuumg5p1b/999999999/2fa/variables.php(34): Jocic\GoogleAuthenticator\Account->__construct('Example', 'example@cwinfo....', 'JVIVET2MKBJUEU2 in {FOLDER}/system/external/jocic/google-authenticator/source/Jocic/GoogleAuthenticator/Secret.php on line 194

@cwchristerw
Copy link
Author

cwchristerw commented May 6, 2019

Temporarily fixed this with changing length check in Secret.php because in FreeOTP minimum legth for secret is 8

            // Step 1 - Check Length
            
            if (count($characters) < 8)
            {
                return false;
            }

@jocic
Copy link
Owner

jocic commented Jun 5, 2019

Thank you for reporting the issue, I will resolve it as soon as possible!

@amjithps
Copy link

Is this issue solved?

@jocic
Copy link
Owner

jocic commented Feb 12, 2020

Yes, issue has been resolved.

@jocic jocic closed this as completed Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants