Update GS1 datasets #292
Merged
Update GS1 datasets #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
jodal
commented
Jun 30, 2024
jodal
commented
- Update GS1 AI script to use new data source
- Update GS1 AI dataset
- Update tests with updated AI patterns
- Update GS1 Company Prefix dataset
- Update GS1 Prefix dataset
GS1 now provides a proper JSON dataset, so we don't have to defer to webscraping.
...so this check is dead code.
The changes are primarily related to stricter patterns for dates and GRAI values.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #292 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 18 18
Lines 951 949 -2
Branches 146 145 -1
=========================================
- Hits 951 949 -2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.