Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve types through typing all tests #195

Merged
merged 6 commits into from Jun 7, 2023
Merged

Improve types through typing all tests #195

merged 6 commits into from Jun 7, 2023

Conversation

jodal
Copy link
Owner

@jodal jodal commented Jun 7, 2023

  • Upgrade pyright to 1.1.313
  • Name type vars consistently
  • Make ActorRef and ActorProxy generic
  • Change the return type of ActorProxy.__getattr__() to Any
  • Fully type test suite

@codecov
Copy link

codecov bot commented Jun 7, 2023

Codecov Report

Patch coverage: 94.73% and project coverage change: +0.14 🎉

Comparison is base (952b5ea) 90.57% compared to head (ace6232) 90.72%.

❗ Current head ace6232 differs from pull request most recent head 3d92e9c. Consider uploading reports for the commit 3d92e9c to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #195      +/-   ##
==========================================
+ Coverage   90.57%   90.72%   +0.14%     
==========================================
  Files          12       12              
  Lines         573      582       +9     
==========================================
+ Hits          519      528       +9     
  Misses         54       54              
Impacted Files Coverage Δ
src/pykka/_ref.py 88.15% <71.42%> (+0.15%) ⬆️
src/pykka/_actor.py 91.66% <100.00%> (+0.23%) ⬆️
src/pykka/_future.py 96.42% <100.00%> (+0.13%) ⬆️
src/pykka/_proxy.py 97.39% <100.00%> (+0.02%) ⬆️
src/pykka/_registry.py 94.28% <100.00%> (+0.08%) ⬆️
src/pykka/_threading.py 91.80% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jodal jodal merged commit 174ec10 into main Jun 7, 2023
11 checks passed
@jodal jodal deleted the type-tests branch June 7, 2023 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant