Updated __init__ to include gevent objects; fixed import of Timeout to c... #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o come from pykka.exceptions
| @@ -1,5 +1,6 @@ | |||
| # flake8: noqa | |||
| from pykka.actor import Actor, ActorRef, ThreadingActor | |||
| from pykka.gevent import GeventActor, GeventFuture | |||
There was a problem hiding this comment.
This change will make Pykka unimportable on any system where Gevent isn't available. Thus, it is a no-go.
There was a problem hiding this comment.
Which includes all Python 3 and PyPy systems.
|
D'oh. Sorry about that -- a bit too eager on the pull request. Is there any interest in just wrapping that import in a try/except since things otherwise work well without those imports? |
|
I don't think you save/gain a lot from it, so I'd rather not. Just doing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...ome from pykka.exceptions. Small fixes to enable non-threading actors.