This repository has been archived by the owner on Jun 15, 2022. It is now read-only.
Fix PortAudio underruns (#132) by using async playback #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hm, realized that I didn't update tests. I'll give that a shot later this weekend. |
| @@ -3,12 +3,16 @@ | |||
| import sys | |||
|
|
|||
| import spotify | |||
| import logging | |||
| from collections import deque | |||
There was a problem hiding this comment.
I try to follow Google's Python style guide wrt import ordering, so this would become:
from collections import deque
import logging
import sys
import spotify
|
How is it going with this? |
|
Im also experiencing, would be great if this got merged 😉 |
|
Closing as the approach proposed here has flaws, as discussed 10 months ago. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This switches to async playback and fixes the periodic underruns observed in issue #132. Suggestions on style are welcomed.