Skip to content
This repository has been archived by the owner on Jun 15, 2022. It is now read-only.

Update installation.rst (Instructions for OS X) #157

Closed
wants to merge 1 commit into from
Closed

Update installation.rst (Instructions for OS X) #157

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 5 additions & 1 deletion docs/installation.rst
View file
Open in desktop
Expand Up @@ -63,6 +63,10 @@ libspotify in the homebrew/binary tap::

brew install homebrew/binary/libspotify

Install libffi as a dependency::

brew install libffi

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First, libffi is provided by OS X by default. The Homebrew formula for libffi is "keg-only". Do you know for a fact that the libffi bundled with OS X isn't good enough?

Second, instructions about libffi, which is a cffi/pyspotify dep, should not be in the middle of the libspotify section.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough, I'm very sorry for the hasty pull request. I'll create an issue later instead. libffi is indeed provided by OS X, I had some weird error and don't have the logs at hand. Sorry for the inconvenience.

.. warning::

There's an issue with building pyspotify against libspotify on OS X where
Expand All @@ -71,7 +75,7 @@ libspotify in the homebrew/binary tap::
A known workaround is to create a symlink after installing libspotify, but
before installing pyspotify::

sudo ln -s /usr/local/opt/libspotify/lib/libspotify.12.1.51.dylib \
ln -s /usr/local/opt/libspotify/lib/libspotify.12.1.51.dylib \
/usr/local/opt/libspotify/lib/libspotify

Alternatively, the mopidy/mopidy Homebrew tap has a libspotify formula which
Expand Down