-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support annotations on services created by controller #36
Support annotations on services created by controller #36
Conversation
!depends #35 |
d14f756
to
c4c4de5
Compare
@jodevsa How do I re-generate the CRD interface? |
Hi @Matthew-Beckett, Please also try Btw, I have created a github job to create a release from a repo/branch. This is useful if you wanna easily try your changes on your cluster. Steps to use: 1- head to the actions page and click on the "DEV release" action 2- You should see a button on the right that is called "Run workflow" 3- fill the form with your repo/branch 4- Trigger the workflow by pressing "Run workflow" 5- wait for the build to finish 6- Once your job is done, press on it 7- You should see an "artifacts" section with a release.yaml file 8- click on the file to download it let me know if you have any questions :) |
@jodevsa I am not a contributor/maintainer so I do not have permission to run manual actions. May I recommend migrating this to a GitHub Organisation? |
Sure, let me have a look |
@Matthew-Beckett Can you try again? I gave permissions to everyone to run that flow. I'll have a look at moving this to an organisation soon |
I've also added you as a collaborator. please accept the invite. |
@@ -3,22 +3,17 @@ module github.com/jodevsa/wireguard-operator | |||
go 1.16 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you need go.sum and go.mod to be updated? if not, I would prefer to postpone updating any dependencies in a separate PR if possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, it would be nice if you can remove the go.mod/go.sum changes and do that in a separate PR if possible
btw, did the release workflow work for you? I also wonder if the arm images are working fine |
@jodevsa the dependency update for wgctl is to fix a build failure due to missing artefact, I am not sure how the other changes appeared. Again, not a great Go dev, could you help me understand where they came from and how to revert them? |
This PR adds support to pass annotations in via the CRD spec which will be appended to the service created, this allows the usage of custom annotations which is required for configuring LoadBalancer implementations.