Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support annotations on services created by controller #36

Conversation

Matthew-Beckett
Copy link
Collaborator

This PR adds support to pass annotations in via the CRD spec which will be appended to the service created, this allows the usage of custom annotations which is required for configuring LoadBalancer implementations.

@Matthew-Beckett
Copy link
Collaborator Author

Matthew-Beckett commented Apr 26, 2023

!depends #35

@Matthew-Beckett Matthew-Beckett force-pushed the feature/support-service-annotations branch from d14f756 to c4c4de5 Compare April 29, 2023 12:22
@Matthew-Beckett
Copy link
Collaborator Author

Matthew-Beckett commented Apr 29, 2023

@jodevsa How do I re-generate the CRD interface? make generate?

@jodevsa
Copy link
Owner

jodevsa commented Apr 29, 2023

Hi @Matthew-Beckett,

Please also try make manifests.

Btw, I have created a github job to create a release from a repo/branch. This is useful if you wanna easily try your changes on your cluster.

Steps to use:

1- head to the actions page and click on the "DEV release" action
Screenshot 2023-04-29 at 16 25 23

2- You should see a button on the right that is called "Run workflow"

3- fill the form with your repo/branch

4- Trigger the workflow by pressing "Run workflow"

5- wait for the build to finish

6- Once your job is done, press on it

7- You should see an "artifacts" section with a release.yaml file
Screenshot 2023-04-29 at 16 29 17

8- click on the file to download it
9- kubectl apply -f ~/fileLocation/release.yaml

let me know if you have any questions :)

@Matthew-Beckett
Copy link
Collaborator Author

@jodevsa I am not a contributor/maintainer so I do not have permission to run manual actions. May I recommend migrating this to a GitHub Organisation?

@jodevsa
Copy link
Owner

jodevsa commented Apr 29, 2023

@jodevsa I am not a contributor/maintainer so I do not have permission to run manual actions. May I recommend migrating this to a GitHub Organisation?

Sure, let me have a look

@jodevsa
Copy link
Owner

jodevsa commented Apr 29, 2023

@Matthew-Beckett Can you try again? I gave permissions to everyone to run that flow. I'll have a look at moving this to an organisation soon

@jodevsa
Copy link
Owner

jodevsa commented Apr 29, 2023

I've also added you as a collaborator. please accept the invite.

@Matthew-Beckett
Copy link
Collaborator Author

I've also added you as a collaborator. please accept the invite.

Done, thank you!

@Matthew-Beckett Matthew-Beckett marked this pull request as ready for review April 29, 2023 15:04
@Matthew-Beckett Matthew-Beckett self-assigned this Apr 29, 2023
@Matthew-Beckett Matthew-Beckett added the enhancement New feature or request label Apr 29, 2023
@@ -3,22 +3,17 @@ module github.com/jodevsa/wireguard-operator
go 1.16
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need go.sum and go.mod to be updated? if not, I would prefer to postpone updating any dependencies in a separate PR if possible.

Copy link
Owner

@jodevsa jodevsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, it would be nice if you can remove the go.mod/go.sum changes and do that in a separate PR if possible

@jodevsa
Copy link
Owner

jodevsa commented Apr 29, 2023

btw, did the release workflow work for you? I also wonder if the arm images are working fine

@Matthew-Beckett
Copy link
Collaborator Author

@jodevsa the dependency update for wgctl is to fix a build failure due to missing artefact, I am not sure how the other changes appeared.

Again, not a great Go dev, could you help me understand where they came from and how to revert them?

@Matthew-Beckett Matthew-Beckett merged commit 870277c into jodevsa:main May 9, 2023
2 checks passed
@Matthew-Beckett Matthew-Beckett deleted the feature/support-service-annotations branch May 9, 2023 14:07
@Matthew-Beckett Matthew-Beckett mentioned this pull request May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants