Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creates the Jodit editor instance outside Angular scope #26

Merged
merged 5 commits into from
Mar 12, 2019

Conversation

katan
Copy link

@katan katan commented Feb 26, 2019

What is the current behavior?

In some complex Angular projects (like using material design or other UI libraries) the performance
of the editor go down.

What is the new behavior?

Creates the Jodit editor instance outside Angular scope to prevent a lack performance, using the ngZone method: runOutsideAngular

this.ngZone.runOutsideAngular(() => {
    this.editor = new EditorModule.Jodit(this.element, this.config);
});

Fixes #25
Should be fixes the issue: Jodit is not a constructor

@xdan xdan merged commit 6c0b600 into jodit:master Mar 12, 2019
@entith entith mentioned this pull request May 23, 2019
@Azuka Azuka mentioned this pull request Aug 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jodit is not a constructor
2 participants