Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added additionalPodLabels #121

Merged
merged 3 commits into from
Oct 19, 2022
Merged

Conversation

tehlers320
Copy link
Contributor

Some orgs need labels for cost analysis or other reasons. This is usually something only done on the pods.
#120

Before:

  template:
    metadata:
      labels:
        app.kubernetes.io/name: cert-exporter
        app.kubernetes.io/instance: release-name
        cert-exporter.io/type: deployment
      annotations:
        {}
    spec:

After (with label1/2 set to test):

   template:
    metadata:
      labels:
        app.kubernetes.io/name: cert-exporter
        app.kubernetes.io/instance: release-name
        cert-exporter.io/type: deployment
        label1: test
        label2: test
      annotations:
        {}

@joe-elliott
Copy link
Owner

Nice! Thanks.

@joe-elliott joe-elliott merged commit c66d073 into joe-elliott:master Oct 19, 2022
@tehlers320
Copy link
Contributor Author

@joe-elliott thanks so much!

I realized i forgot to squash my commit though, sorry!

@joe-elliott
Copy link
Owner

joe-elliott commented Oct 21, 2022

No worries. Thank you!

I should really squash on merge :P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants