Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple namespaces for secrets\configMaps don't work. #124

Merged
merged 1 commit into from
Nov 9, 2022

Conversation

Krasttt
Copy link
Contributor

@Krasttt Krasttt commented Nov 7, 2022

Multiple namespaces for secrets\configMaps don't work.

There is problem with secret\configMap slice, if we set two or more namespaces cert-exporter get cert just from last namespace from list. Another certs from other namespaces will be lost.

Changes:

  • configMaps = c.Items to configMaps = append(configMaps, c.Items...)
  • secrets = s.Items to secrets = append(secrets, s.Items...)
  • Adds log about namespaces that will be scan if set parameter for it
  • Adds log error for statement when cert-exporter get secret/configMap with labelSelector

@Krasttt Krasttt changed the title Append slice Multiple namespaces for secrets\configMaps don't work. Nov 8, 2022
@joe-elliott
Copy link
Owner

Nice catch!

Fixes #73

@joe-elliott joe-elliott merged commit 3f14061 into joe-elliott:master Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants