Support for PKCS12/PFX certificates #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EnriqueJoseSanjuaneloRobles-TomTom
changed the title
EnriqueJoseSanjuaneloRobles-TomTom
changed the title
EnriqueJoseSanjuaneloRobles-TomTom
changed the title
joe-elliott
reviewed
Nov 9, 2022
src/exporters/certHelpers.go
Outdated
| // Parse as PKCS ? | ||
| pfx_blocks, err := decodeFromPKCS(certBytes) | ||
| if err != nil { | ||
| return metrics, fmt.Errorf("Failed to parse certificate") |
There was a problem hiding this comment.
let's include an indication that there was an attempt to parse as both pem and the new format in the error message for clarity.
also let's include the reported error. something like:
fmt.Errorf("failed to parse as pem and pkcs12: %w", err)
joe-elliott
approved these changes
Nov 16, 2022
| @@ -37,40 +39,84 @@ func secondsToExpiryFromCertAsBase64String(s string) ([]certMetric, error) { | |||
|
|
|||
| func secondsToExpiryFromCertAsBytes(certBytes []byte) ([]certMetric, error) { | |||
| var metrics []certMetric | |||
|
|
|||
| parsed, metrics, err := parseAsPEM(certBytes) | |||
There was a problem hiding this comment.
i like this refactor, it makes this function more readable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #123
In case a certificate in PKCS12 format is specified (using the same extension as PEM formats), the helper will try to decode its content (given the PEM decoding failed).
A test case is included is also added as well.