Fix: pod not picking up role from service account #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joe-elliott
reviewed
Dec 5, 2023
src/checkers/periodicAwsChecker.go
Outdated
| @@ -43,7 +43,8 @@ func (p *PeriodicAwsChecker) StartChecking() { | |||
| p.exporter.ResetMetrics() | |||
|
|
|||
| // Create a Session with a custom region | |||
| svc := secretsmanager.New(session.New(), aws.NewConfig().WithRegion(p.awsRegion)) | |||
| session, _ := session.NewSession() | |||
There was a problem hiding this comment.
if this returns an error we should log it and increment the errors metric
There was a problem hiding this comment.
Hey @joe-elliott. Definitely makes sense. :) Added logging and error counter increment. Thanks for the swift reply!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
cert-exporterdoes not properly assume the role stored in env variableAWS_ROLE_ARN. Apparently, switching fromsession.New()tosession.NewSession()should fix it: aws/aws-sdk-go#4436