Skip to content
This repository has been archived by the owner on Jun 27, 2021. It is now read-only.

installer problems #70

Closed
joe27g opened this issue Mar 25, 2019 · 2 comments
Closed

installer problems #70

joe27g opened this issue Mar 25, 2019 · 2 comments
Labels
category: installer Something related to the installer/install process. priority: high Needs to be fixed or implemented as soon as possible. status: planned Considered as a to-do; will be worked on in the near future type: bug Something isn't working

Comments

@joe27g
Copy link
Owner

joe27g commented Mar 25, 2019

ok, so several people have had problems with being unable to launch discord due to the injection path being wrong/ the file not existing. to ensure that these errors are non-destructive, some of the following should be done:

  • download and extract the ED files BEFORE injecting
  • check that the path exists before setting it as the injection file
  • maybe add a note saying to uninject before deleting injection file

also, a note that's somewhat related: checking registry entry Computer\HKEY_CLASSES_ROOT\Discord\shell\open\command could make the installer better.
@joe27g joe27g added type: bug Something isn't working status: planned Considered as a to-do; will be worked on in the near future priority: high Needs to be fixed or implemented as soon as possible. category: installer Something related to the installer/install process. labels Mar 25, 2019
@YouKnowBlom
Copy link
Collaborator

Sounds good overall. I'd also like to add: having the ability to manually specify the path to index.js, just for edge cases

@tommyettinger
Copy link

I am having this injection path problem; is there a known solution?

@joe27g joe27g mentioned this issue Feb 22, 2020
Open
6 tasks
@joe27g joe27g closed this as completed Feb 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
category: installer Something related to the installer/install process. priority: high Needs to be fixed or implemented as soon as possible. status: planned Considered as a to-do; will be worked on in the near future type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tommyettinger @YouKnowBlom @joe27g