Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to handle non Adafruit supplied libraries #122

Merged
merged 1 commit into from
Dec 30, 2023

Conversation

veggie2u
Copy link
Contributor

Currently when you try to list libraries the code takes the filename and tries to look up information about it from the Adafruit libraries. If that file or folder is not found in the list, a fairly hidden error happens and it looks like nothing happened.

This change will use the information from the filename and print out the version and a message. No action is allowed on this library.

In the future it would be interesting to also pull community libraries or allow other library locations to find this upgrade info.

You can see in the image that bluepad32 which is not an Adafruit library show in the list as no updateable.

image

@veggie2u
Copy link
Contributor Author

This should resolve this reported bug: #89

Copy link

@tyeth tyeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks sensible enough 👍

@tyeth
Copy link

tyeth commented Nov 17, 2023

It's worth noting in response to your comments and the idea in general, that the official package manager circup now has support for a pyproject.toml (adafruit/circup#188) to define dependencies.
At the time of the review, on a live stream (adafruit circuitpython deep dives - this time foamyguy, can watch his twitch stream specifically https://www.twitch.tv/videos/1968511177) it was talked about it being useful to support some non-community packages too, ideally git repos.

@joedevivo joedevivo merged commit a673c1b into joedevivo:master Dec 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants