Skip to content
This repository has been archived by the owner on Jan 24, 2020. It is now read-only.

Fix crash when expiresDate is nil #121

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Fix crash when expiresDate is nil #121

wants to merge 5 commits into from

Conversation

marcshilling
Copy link
Contributor

Fixes #120

@lukecyca
Copy link

lukecyca commented Nov 8, 2018

I tested this branch with my app and can confirm that it fixes #120. 👍

Thanks for the help!

@michalakjan michalakjan mentioned this pull request Feb 8, 2019
Open
@mojodna mojodna mentioned this pull request Mar 15, 2019
Open
enahum
enahum approved these changes Apr 25, 2019
View reviewed changes
Copy link

@enahum enahum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to make this change in our fork to solve the crash and it worked beautifully

@maxKimoby
Copy link

Can we get this merged please?

@safaiyeh
Copy link

Thanks! Greetings from 1 year later.

@safaiyeh
Copy link

I have forked the repo here: https://github.com/safaiyeh/react-native-cookie-store
We can create issues and PRs there to continue the development of the project.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@enahum enahum enahum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crash when loading session cookie
6 participants
@marcshilling @lukecyca @maxKimoby @safaiyeh @enahum @joeferraro