This repository has been archived by the owner on Jan 24, 2020. It is now read-only.
Fix clearAll(useWebKit = true) #150
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyleralves
reviewed
Jul 10, 2019
| [[WKWebsiteDataStore defaultDataStore] removeDataOfTypes:websiteDataTypes | ||
| modifiedSince:dateFrom | ||
| completionHandler:^{}]; | ||
| resolve(nil); |
There was a problem hiding this comment.
Would it make sense to put resolve(nil) within the completion handler of WKWebsiteDataStore::defaultDataStore so that it doesn't resolve prior to the cookies being deleted?
There was a problem hiding this comment.
Agreed. Implemented in c0bfc05.
|
FWIW, I made a patch for our local copy. Seems like this repo isn't actively maintained. |
|
I have forked the repo here: https://github.com/safaiyeh/react-native-cookie-store |
5 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #127