Skip to content
This repository has been archived by the owner on Oct 4, 2019. It is now read-only.

Include windows 2012 and Virtualbox builder declarations #1

Merged
merged 2 commits into from
Sep 18, 2013
Merged

Include windows 2012 and Virtualbox builder declarations #1

merged 2 commits into from
Sep 18, 2013

Conversation

dylanmei
Copy link
Collaborator

This may not be the direction you were going, but I've added a Windows 2012 and Virtualbox builder declarations. I'm also using Puppet instead of Chef so found myself arranging the scripts differently.

@joefitzgerald
Copy link
Owner

Thanks for the contribution, Dylan... I will validate on VMware Fusion tonight, but the changes look good. Cheers!

@dylanmei
Copy link
Collaborator Author

Good news, thanks. Cheers

@sneal
Copy link
Collaborator

sneal commented Sep 17, 2013

@dylanmei 👍

@joefitzgerald joefitzgerald merged commit a8f76bb into joefitzgerald:master Sep 18, 2013
@joefitzgerald
Copy link
Owner

@dylanmei Had to make a couple of minor changes to the VMware provisioners, but otherwise all good. Thanks again for the contribution!

@dylanmei @sneal I have been thinking about introducing a build process to generate the .json file for a specific OS / provisioner combination (e.g. Windows 2008 R2 + Puppet vs Windows 2012 + Chef). I think this would help to support many different configurations without having an increasing amount of duplication. Windows Server 2012 R2 will be out any time now, and with Chef / Puppet / No provisioner variants, the number of JSON files we maintain will spiral out of control.

What do you think?

@sneal
Copy link
Collaborator

sneal commented Sep 18, 2013

If there's enough duplication between json files then I think that makes a lot of sense. Would it hurt customizability?

@dylanmei
Copy link
Collaborator Author

A template to bootstrap the template. :) Ideally the customizability is covered in provisioning. I could do a lot with a build that did a bare bones Autounattended.xml, installed cygwin, VM tools/additions, and then simply picked up provisioning snippets from a directory.

@dylanmei dylanmei deleted the include_windows_2012 branch September 19, 2013 13:46
@joefitzgerald
Copy link
Owner

@sneal @dylanmei Moved this discussion to #3.

stefanschneider pushed a commit to stefanschneider/packer-windows that referenced this pull request Aug 21, 2016
stefanschneider pushed a commit to stefanschneider/packer-windows that referenced this pull request Aug 21, 2016
mosen pushed a commit to mosen/packer-windows that referenced this pull request Nov 24, 2017
rivy pushed a commit to rivy/packer-windows that referenced this pull request Apr 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants