Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preflight OPTIONS bug fix #125

Closed
joegasewicz opened this issue Dec 11, 2019 · 0 comments · Fixed by #126
Closed

Preflight OPTIONS bug fix #125

joegasewicz opened this issue Dec 11, 2019 · 0 comments · Fixed by #126
Assignees
@joegasewicz
Labels
bug Something isn't working

Comments

@joegasewicz
Copy link
Owner

joegasewicz commented Dec 11, 2019 •
edited
Loading

Preflight OPTIONS bug fix introduced another bug: #63
after the OPTION verb gets passed through without authenticating the bug fix also pushes all verbs through.

To fix this issue we need to only worry about the preflight request, the following VERB request then gets past through FJR as normal.
@joegasewicz joegasewicz added the bug Something isn't working label Dec 11, 2019
@joegasewicz joegasewicz self-assigned this Dec 11, 2019
joegasewicz added a commit that referenced this issue Dec 11, 2019
@joegasewicz
Pre-flight OPTIONS only set on POST #63
6ee6619 
**Release 0.0.26** - 2019-12-11

- Preflight OPTIONS bug fix [Issue #125](#125)
@joegasewicz joegasewicz mentioned this issue Dec 11, 2019
Merged
joegasewicz added a commit that referenced this issue Dec 11, 2019
@joegasewicz
Pre-flight OPTIONS only set on POST #63
dc9f570 
**Release 0.0.26** - 2019-12-11

- Preflight OPTIONS bug fix [Issue #125](#125)
joegasewicz added a commit that referenced this issue Dec 11, 2019
@joegasewicz
Pre-flight OPTIONS only set on POST #63
4772eb6 
**Release 0.0.26** - 2019-12-11

- Preflight OPTIONS bug fix [Issue #125](#125)
joegasewicz added a commit that referenced this issue Dec 11, 2019
@joegasewicz
Pre-flight OPTIONS only set on POST #63
91dc443 
**Release 0.0.26** - 2019-12-11

- Preflight OPTIONS bug fix [Issue #125](#125)
joegasewicz added a commit that referenced this issue Dec 11, 2019
@joegasewicz
Pre-flight OPTIONS only set on POST #63
1c01430 
**Release 0.0.26** - 2019-12-11

- Preflight OPTIONS bug fix [Issue #125](#125)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joegasewicz joegasewicz

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Pre-flight OPTIONS only set on POST #63 joegasewicz/flask-jwt-router
1 participant
@joegasewicz