Multiple FileRef calls creates infinite loop error Fixes #96 (#97)

joegasewicz · Jan 20, 2021 · 7bcc663 · 7bcc663
1 parent 3fcbc50
commit 7bcc663
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/showcase/main.tsx b/showcase/main.tsx
@@ -25,6 +25,7 @@ import {
 interface IProps{}
 
 const myFileRef = createFileRef();
+const myFileRef2 = createFileRef();
 
 interface IState{
 
@@ -100,6 +101,7 @@ export class Main extends React.Component<IProps, IState> {
             radio3: false,
             fruitChoice: "",
             myFileTest: getFileFromRef(myFileRef),
+            myFileTest2: getFileFromRef(myFileRef2),
         }
 
     };
@@ -184,6 +186,13 @@ export class Main extends React.Component<IProps, IState> {
                                     name="myFileTest"
                                     validators={[isFile()]}
                                 />
+                                <FileField
+                                    ref={myFileRef2}
+                                    hint="Must be a file"
+                                    labelText="Upload your file"
+                                    name="myFileTest"
+                                    validators={[isFile()]}
+                                />
 
                                 <RadioGroup name="group1">
                                     <RadioField

diff --git a/src/core/_MetadataFile.tsx b/src/core/_MetadataFile.tsx
@@ -54,7 +54,9 @@ export class MetadataFile<T extends IFieldValidation> extends AbstractMetadata<T
                         isTouched: true,
                     },
                 };
-                this.updateState(state);
+                useEffect(() => {
+                   this.updateState(state);
+                }, [state]);
             }
         }
     }