This repository has been archived by the owner on Dec 7, 2020. It is now read-only.
Simplify the consumer. #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
| msg_decoder_i = Java::JavaClass.for_name(@msg_decoder). | ||
| constructor('kafka.utils.VerifiableProperties').new_instance nil | ||
|
|
||
| if @topic |
There was a problem hiding this comment.
would it be worth turning @topic into an attr_reader since that field should be immutable once the class is initialized?
There was a problem hiding this comment.
There is no way to change @topic from outside class, as @topic is not an attribute. You could make use of attr_reader and only use the topic attribute within the class, but that just seems like wearing suspenders with a belt. @topic is for all intents and purposes already immutable since its not modified after initialization.
|
Thanks for the contribution! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A proposed simplification of the consumer (see #32 for a discussion of the problem with the current design). It drops the unnecessary queue nor those it force the user to use a thread pool. It is just a shallow Ruby layer over the Kafka high-level consumer. Like it exposes the message streams to the user and allows him to select how many streams he wants. If the user wants the old behavior of all messages multiplexed into a single queue, all they have to do is choose a single stream. The Kafka consumer group example can then be easily reproduced by the user, outside of the library.