Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.x] fix: remove typehint to be compatible with Socialite AbstractProvider #330

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

okaufmann
Copy link
Contributor

@okaufmann okaufmann commented Jan 22, 2024

Summary

This pull request addresses a compatibility issue with Laravel Socialite's AbstractProvider by updating the RefreshesOAuth2Tokens trait.

Explanation

RefreshesOAuth2Tokens is no longer compatible with Laravel Socialite's AbstractProvider. They added the method refreshToken 2 Months ago which now conflicts with the trait.

Checklist

  • I've read this template
  • I've checked reviewed this PR myself, ensuring consistency and quality with the rest of the project
  • I've given a good reason as to why this PR exposes new / removes existing user data

@joelbutcher joelbutcher changed the title fix: remove typehint to be compatible with Socialite AbstractProvider [5.x] fix: remove typehint to be compatible with Socialite AbstractProvider Jan 23, 2024
@joelbutcher joelbutcher merged commit 6469281 into joelbutcher:5.x Jan 23, 2024
62 checks passed
@okaufmann okaufmann deleted the fix-refresh-token-trait branch January 23, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants