Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.x] Fix removed cancel modal toggle action #338

Conversation

Philrobots
Copy link
Contributor

@Philrobots Philrobots commented Mar 5, 2024

Problem description

At line 71, of the connected-accounts-form.blade.php

The value :

"$toggle('confirmingRemove')"

does not seems to exist anymore, it should be remove by :

"$toggle('confirmingAccountRemoval')"

   <x-slot name="footer">
                <x-secondary-button wire:click="$toggle('confirmingRemove')" wire:loading.attr="disabled">
                    {{ __('Cancel') }}
                </x-secondary-button>

                <x-danger-button class="ml-2" wire:click="removeConnectedAccount" wire:loading.attr="disabled">
                    {{ __('Remove Account') }}
                </x-danger-button>
            </x-slot>

Expected behavior

Should be :

 <x-slot name="footer">
                <x-secondary-button wire:click="$toggle('confirmingAccountRemoval')" wire:loading.attr="disabled">
                    {{ __('Cancel') }}
                </x-secondary-button>

                <x-danger-button class="ml-2" wire:click="removeConnectedAccount" wire:loading.attr="disabled">
                    {{ __('Remove Account') }}
                </x-danger-button>
            </x-slot>

@joelbutcher joelbutcher changed the title bug(): Fix depricated variable in connected-accounts-form.blade file [5.x] Fix removed cancel modal toggle action Mar 5, 2024
@joelbutcher joelbutcher merged commit e4b8750 into joelbutcher:5.x Mar 5, 2024
62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants