Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.x] Remove webmozart/assert package #352

Merged
merged 2 commits into from
Apr 1, 2024

Conversation

miguilimzero
Copy link
Contributor

Summary

This pull request removes the webmozart/assert package. The package is used in only one file to throw InvalidArgumentException in some scenarios. Although these exceptions are never caught, the PR manually adds the exceptions with the exact same messages from the package.

The motivation for this PR is because the package is giving some strange conflict errors when trying to install vimeo/psalm with socialstream and webmozart/asset with an already composer.lock generated.

Manually adding vimeo/psalm to the project and deleting the composer.lock fixes the conflict. However, since this package's last commit was 2 years ago and is only being used in one single file, I personally don't see a reason to keep it.

Checklist

  • I've read this template
  • I've checked reviewed this PR myself, ensuring consistency and quality with the rest of the project
  • I've given a good reason as to why this PR exposes new / removes existing user data

@miguilimzero miguilimzero changed the title [6.x] Remove abandoned webmozart/assert package [6.x] Remove webmozart/assert package Mar 29, 2024
@joelbutcher
Copy link
Owner

However, since this package's last commit was 2 years ago and is only being used in one single file, I personally don't see a reason to keep it.

Which commit / package are you referring to here?

@miguilimzero
Copy link
Contributor Author

@joelbutcher https://github.com/webmozarts/assert package. The last commit was on Jun 3, 2022.

@joelbutcher joelbutcher merged commit b2fc2e8 into joelbutcher:6.x Apr 1, 2024
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants