Implementing SystemJSPublicPathWebpackPlugin. Resolves #12. #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeldenning
commented
Nov 30, 2020
|
|
||
| module.exports = { | ||
| plugins: [ | ||
| new SystemJSPublicPathWebpackPlugin({ |
There was a problem hiding this comment.
My thought is we can add this to webpack-config-single-spa, and then remove the set-public-path.js files entirely from all the templates.
frehner
reviewed
Nov 30, 2020
| class SystemJSPublicPathWebpackPlugin { | ||
| constructor(options) { | ||
| this.options = options || {}; | ||
| if (!isWebpack5 && !this.options.systemjsModuleName) { |
There was a problem hiding this comment.
to be a little more future-proof, could we do a check here for if it's >=5 or <5? otherwise we'll have issues when v6 is out
There was a problem hiding this comment.
i didn't want to bring in the full semver library - my understanding is that package.json version numbers don't even have to be numbers? Not sure if they have to start with numbers, either.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #12