Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Encoding systemjs module name to work with Windows #18

Merged
merged 2 commits into from
Dec 15, 2020
Merged

Encoding systemjs module name to work with Windows #18

merged 2 commits into from
Dec 15, 2020

Conversation

emdap
Copy link
Contributor

@emdap emdap commented Dec 15, 2020

  • Encode the systemjsModuleName to avoid forward-slash to back-slash conversion
  • Decode the systemjsModuleName when setting public path

joeldenning
joeldenning approved these changes Dec 15, 2020
View reviewed changes
Copy link
Owner

@joeldenning joeldenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this.

@joeldenning joeldenning merged commit ed4718f into joeldenning:master Dec 15, 2020
This was referenced Dec 15, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joeldenning joeldenning joeldenning approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@emdap @joeldenning