Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove kJLRouteParametersKey and pass other top-level params in the single dictionary #2

Closed
pwightman opened this issue Feb 11, 2013 · 2 comments
Milestone

Comments

@pwightman
Copy link

Curious as to why you have to fetch another dictionary out of the dictionary given? Is there other stuff in the root dict? If so, can it be described in the README? Seems like an arbitrary obstacle, so I'm sure you had good reason for it, just curious what it is.

Great lib! I'll be coming back to this very soon.

@joeldev
Copy link
Owner

joeldev commented Feb 11, 2013

In the root dictionary you also get the URL that caused that block to be called and the pattern string (which may be a useless addition but it was easy to throw in there).

I will update the README to reflect what currently gets passed.

I am actually thinking about changing this, now that you bring it up.

On Mon, Feb 11, 2013 at 12:46 AM, Parker notifications@github.com wrote:

Curious as to why you have to fetch another dictionary out of the dictionary given? Is there other stuff in the root dict? If so, can it be described in the README? Seems like an arbitrary obstacle, so I'm sure you had good reason for it, just curious what it is.

Great lib! I'll be coming back to this very soon.

Reply to this email directly or view it on GitHub:
#2

@joeldev
Copy link
Owner

joeldev commented Feb 11, 2013

Updated title to something actionable

joeldev added a commit that referenced this issue Feb 11, 2013
@joeldev joeldev closed this as completed Feb 11, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants