Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When creating job, create folder if not existed. #48

Merged
merged 5 commits into from
Apr 8, 2022
Merged

When creating job, create folder if not existed. #48

merged 5 commits into from
Apr 8, 2022

Conversation

fz0000
Copy link
Contributor

@fz0000 fz0000 commented Apr 5, 2022

I'd like to use:

j.create_job('path/to/job', xml_freestylejob)

instead of:

j.create_job('path', xml_emptyfolder)
j.create_job('path/to', xml_emptyfolder)
j.create_job('path/to/job', xml_freestylejob)

@fz0000
add some job xml templates
bb9e7af 
Signed-off-by: fangzheng <fz0000@sina.com>
@fz0000
when creating the job, recursively create the folder if it does not e…
64ade52 
…xist.

Signed-off-by: fangzheng <fz0000@sina.com>
@fz0000
format
36614df 
Signed-off-by: fangzheng <fz0000@sina.com>
@fz0000
format
ee1815d 
Signed-off-by: fangzheng <fz0000@sina.com>
joelee2012
joelee2012 reviewed Apr 6, 2022
View reviewed changes
api4jenkins/__init__.py Outdated
@@ -120,6 +120,8 @@ def create_job(self, full_name, xml):
<FreeStyleProject: http://127.0.0.1:8080/job/freestylejob/>
'''
folder, name = self._resolve_name(full_name)
if not folder.exists():
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about add parameter recursive with default value False to let user make choice ?
and please add test case as well, thanks

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added. thanks.
I only added in test_create_job_succ. Maybe some test cases are also needed in test_create_job_fail. 🤔

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's pretty good.

@fz0000
add recursive parameter for create_job
a7141c5 
add tests.

Signed-off-by: fangzheng <fz0000@sina.com>
@joelee2012 joelee2012 merged commit 714083c into joelee2012:master Apr 8, 2022
@fz0000 fz0000 mentioned this pull request Jun 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joelee2012 joelee2012 joelee2012 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fz0000 @joelee2012