Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Object as the type in case schema property contains mixed types #1456

Merged
merged 1 commit into from
Feb 15, 2023
Merged

Use Object as the type in case schema property contains mixed types #1456

merged 1 commit into from
Feb 15, 2023

Conversation

unkish
Copy link
Collaborator

@unkish unkish commented Dec 21, 2022

Closes #1425

@unkish unkish force-pushed the issues/1425 branch 2 times, most recently from 5bb3995 to 5edd3a7 Compare January 8, 2023 18:50
@unkish unkish force-pushed the issues/1425 branch 2 times, most recently from 024c0e4 to 7436e4d Compare January 26, 2023 09:29
@unkish unkish force-pushed the issues/1425 branch 2 times, most recently from 6c21bbb to dad10ce Compare February 7, 2023 14:16
@joelittlejohn joelittlejohn merged commit a3f47de into joelittlejohn:master Feb 15, 2023
@joelittlejohn joelittlejohn added this to the 1.2.0 milestone Feb 15, 2023
@unkish unkish deleted the issues/1425 branch February 15, 2023 10:01
@unkish
Copy link
Collaborator Author

unkish commented Feb 15, 2023 •
edited

Should it be labeled as breaking as logic is slightly different now ?

@joelittlejohn
Copy link
Owner

Yes, you're right.

@prndrsn prndrsn mentioned this pull request Mar 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joelittlejohn joelittlejohn joelittlejohn left review comments

Assignees
No one assigned
Labels
breaking
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.

Generated attribute takes first type on types list.
2 participants
@unkish @joelittlejohn