Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid output to System.err when finding unique Enum name #1485

Merged
merged 1 commit into from
Feb 16, 2023

Conversation

joelittlejohn
Copy link
Owner

No description provided.

@joelittlejohn joelittlejohn added this to the 1.2.0 milestone Feb 15, 2023
Copy link
Collaborator

@unkish unkish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New logged out message makes more sense now also (sample from EnumIT::enumWithNoValidCharactersForIdentifier output):

Enum name __EMPTY__ already used; trying to replace it with __EMPTY___
Enum name __EMPTY___ already used; trying to replace it with __EMPTY____
Enum name __EMPTY__ already used; trying to replace it with __EMPTY____

vs.

[warn] Enum name __EMPTY__ already used; trying to replace it with __EMPTY___
[warn] Enum name __EMPTY__ already used; trying to replace it with __EMPTY___
[warn] Enum name __EMPTY___ already used; trying to replace it with __EMPTY____

@joelittlejohn joelittlejohn merged commit ef5893b into master Feb 16, 2023
@joelittlejohn joelittlejohn deleted the avoid-system-err branch February 16, 2023 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants