Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump com.fasterxml.jackson.* dependencies from 2.14.2 to 2.15.2 #1548

Conversation

unkish
Copy link
Collaborator

@unkish unkish commented Jul 30, 2023

Closes #1531 and #1532

  • bump gradle version from 6.8.3 to 7.6.1 in jsonschema2pojo-gradle-plugin/example/android (version supporting multi-release jar)

* bump gradle version from 6.8.3 to 7.6.1 in jsonschema2pojo-gradle-plugin/example/android (version supporting multi-release jar)
@unkish
Copy link
Collaborator Author

unkish commented Jul 30, 2023

Short description of build failure reason

It appears that there are 2 issues at play:

  1. "Failed to transform jackson-core-2.15.0.jar" / "Workarounds for Jetifier issues"

    In the meantime, I found a workaround which is disabling Jetifier for jackson-core by adding the following to gradle.properties: android.jetifier.ignorelist = jackson-core

    Case 2: If you still need Jetifier to migrate other libraries, but not the one that is failing your build, then you can disable Jetifier specifically for that library by setting

  2. "Gradle 7.4 fails on multi release jar's with JDK 19 code #24390"

Version 2.15.0-rc1 of jackson-core introduces a multi-release jar [link to release notes], which is likely the reason why this error occurs on this particular version and not earlier versions.

Notes

  • gradle versions in jsonschema2pojo-gradle-plugin\example\java and jsonschema2pojo-gradle-plugin were not updated.

Would it make sense to update (align) them as well ?

@joelittlejohn
Copy link
Owner

Thanks for this change. I think we can leave the gradle version alone in jsonschema2pojo-gradle-plugin\example\java and show the earliest version supported. I'm also happy to leave it alone in jsonschema2pojo-gradle-plugin to avoid any problems with the release. We can update as we need to.

@joelittlejohn joelittlejohn added this to the 1.2.2 milestone Jul 31, 2023
@joelittlejohn joelittlejohn merged commit 628d11b into joelittlejohn:master Jul 31, 2023
3 checks passed
@unkish unkish deleted the dependencies/com.fasterxml.jackson-2.15.2 branch August 1, 2023 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CVE => take Jackson 2.15.*
2 participants